On 04/22/2010 10:45 AM, Stephen Shaw wrote:
On Thu, Apr 22, 2010 at 07:55, Daniel P. Berrange <berrange@redhat.com> wrote:
On Thu, Apr 22, 2010 at 09:39:57AM -0400, Chris Lalancette wrote:
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 5f4adfd..4ec4bd6 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c
<trim>
Ok, I just applied that patch in the spec file and rebuilt. I ran virsh snapshot-create a couple time with virt-manager running and connected. Exited cleanly with no apparent problems. I also ran virsh snapshot-revert with no problems (hadn't tested this before so, I'm not saying there was a problem before) and impressed. Though it seems that being able to give a snapshot a name and not some random numerical string would be very/extremely useful.
Great, thanks for the testing! I'll clean the patch up with the recommendations from Dan and post it for 0.8.1. Note that you can specify a name when taking a snapshot; you just need to provide the appropriate XML snippet. Something like the following should work: # cat<< EOF > snapshot.xml <domainsnapshot> <name>myname</name> <description>this is my description</description> </domainsnapshot> EOF # virsh snapshot-create myguest snapshot.xml -- Chris Lalancette