On 12/19/2012 11:21 AM, Daniel P. Berrange wrote:
On Wed, Dec 19, 2012 at 11:14:15AM +0100, Viktor Mihajlovski wrote:
I think Eric means that on non-GCC this code:
# if BROKEN_GCC_WLOGICALOP # pragma GCC diagnostic ignored "-Wlogical-op" # endif
will cause the compiler to complain "Unknown pragma GCC diagnostic..." since obviously non-GCC compilers don't understand GCC pragmas
Daniel
I understood that part. My statement is that BROKEN_GCC_WLOGICALOP will not be defined if configure was run on a system with non-GCC compiler. Unless I oversaw something fundamental ... which I will never rule out. OTOH I am fine with any approach that let's me build on my back-level RHEL6 box for the time being. BTW: there's still a build/install issue for non-systemd systems, see https://www.redhat.com/archives/libvir-list/2012-December/msg01051.html -- Mit freundlichen Grüßen/Kind Regards Viktor Mihajlovski IBM Deutschland Research & Development GmbH Vorsitzender des Aufsichtsrats: Martina Köderitz Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294