Re: [libvirt] [PATCH v2] Convert 'raw MAC address' usages to use virMacAddr
On 07/16/2012 07:16 PM, Eric Blake wrote:
On 07/16/2012 05:14 AM, Stefan Berger wrote:
> @@ -127,7 +121,7 @@ struct _nwItemDesc {
> virNWFilterVarAccessPtr varAccess;
> enum attrDatatype datatype;
> union {
> - nwMACAddress macaddr;
> + virMacAddr macaddr;
> virSocketAddr ipaddr;
> bool boolean;
> uint8_t u8;
Were these all intended to be aligned?
I don't think they need to be.
In general, I only found formatting nits; the first two issues I pointed
out aren't show-stoppers. Let's get this in now, since it touches a lot
of files, and is mostly mechanical.
ACK.
I pushed this now with the formatting nits corrected.
Stefan