Re: [libvirt] [PATCH 2/6] qemuxml2argvtest: Don't spawn session daemon
On 07/09/2018 02:05 PM, Daniel P. Berrangé wrote:
On Mon, Jul 09, 2018 at 02:00:06PM +0200, Michal Privoznik wrote:
> On 07/09/2018 12:44 PM, Daniel P. Berrangé wrote:
>> On Mon, Jul 09, 2018 at 11:56:10AM +0200, Michal Privoznik wrote:
>> In qemuxml2argvtest.c we actally set a fake shared
connection, but I only
>> set it for two of the drivers. We should just register it for all the
>> drivers. eg expand these lines:
>>
>> virSetConnectSecret(conn);
>> virSetConnectStorage(conn);
>
> Oh, that means I have to provide some basic implementation. I can't just
> set conn->nwFilterDriver = NULL; because then virGetConnectNWFilte()
> would still try to connect.
You shouldn't have to provide any impl - virGetConnectNWFilter() merely
cares about the virConnectPtr being non-NULL - it doesn't check if the
conn->nwfilterDriver pointer is set.
Well, in that case there are couple of errors reported (not sure why
they are being printed into stderr rather than respecting log settings?)
libvirt.git/tests $ VIR_TEST_RANGE=460 ./qemuxml2argvtest
TEST: qemuxml2argvtest
libvirt: Network Filter Driver error : this function is not
supported by the connection driver: virNWFilterBindingLookupByPortDev
libvirt: Network Filter Driver error : this function is not supported by
the connection driver: virNWFilterBindingLookupByPortDev
libvirt: Network Filter Driver error : this function is not supported by
the connection driver: virNWFilterBindingLookupByPortDev
. 1602 OK
Michal