Re: [libvirt] [TCK] [PATCH] Add --physdev-is-bridged to test cases
On 01/24/2013 12:48 PM, Laine Stump wrote:
On 01/24/2013 11:34 AM, Stefan Berger wrote:
> Follow recent changes in libvirt and add --physdev-is-bridged to test cases where
needed.
ACK. (Does this mean that new libvirt-tck will fail when run against an
older libvirt, though?)
I hadn't seen this message.
Yes, due to other rules now being generated the effect will be that
previous version of libvirt will fail that test.
By the way, when the patch went into libvirt, the person who posted it
mentioned that when restarting libvirtd after the first upgrade with
that patch, the existing rules wouldn't get removed because they
wouldn't be an exact match to what libvirt was trying to remove:
On 01/18/2013 02:44 AM, Reinier Schoof wrote:
> On a side note, please be aware that when upgrading to a libvirt
> version with this patch included, libvirt will not be able to remove
> the earlier ip(6)tables rules without the '--physdev-is-bridged'
> addition. When restarting libvirt, it will look for rules that match
> with '--physdev-is-bridged' and since that wasn't there before,
you'll
> end up with a duplicate/malfunctioning ruleset. You'll have to remove
> these rules/chains manually.
Is this actually a problem? I had thought that nwfilter always removed
entire chains instead of individual rules.
It will leave a stray rule and a user-defined table behind. I hadn't
tested an update and didn't think of this problem. Let me see how I can
solve this...
Stefan