[libvirt] [PATCH] virsh: help: Drop 'id' from possible values for <domain> argument
At the moment, we can only rename inactive domains.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1490164
Signed-off-by: Erik Skultety <eskultet(a)redhat.com>
---
Theoretically, we could also remove this check from qemu_driver.c as it's a
useless check, given that a VM which passes the 'active' check is going to be a
persistent domain:
if (!vm->persistent) {
virReportError(VIR_ERR_OPERATION_INVALID, "%s",
_("cannot rename a transient domain"));
goto endjob;
}
Also, virshCommandOptDomainBy could be used instead of virshCommandOptDomain in
this case, but we might as well enable rename for active domains as well, who
knows and I don't think this is worth any more attention that just a help string
tweak.
tools/virsh-domain.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index f235c66b0..84c8dccae 100644
--- a/tools/virsh-domain.c
+++ b/tools/virsh-domain.c
@@ -10151,7 +10151,7 @@ static const vshCmdInfo info_domrename[] = {
};
static const vshCmdOptDef opts_domrename[] = {
- VIRSH_COMMON_OPT_DOMAIN_FULL,
+ VIRSH_COMMON_OPT_DOMAIN(N_("domain name or uuid")),
{.name = "new-name",
.type = VSH_OT_DATA,
.flags = VSH_OFLAG_REQ,
--
2.13.3