Re: [libvirt] [PATCH v2 2/4] util: virhostcpu: factor out frequency parsing

On Wed, 2017-12-13 at 17:35 +0100, Pino Toscano wrote: > > + while (fgets(line, sizeof(line), cpuinfo) != NULL) { > > + if (!STRPREFIX(line, prefix)) > > + continue; > > IMHO here it would be a good idea to check that line[strlen(prefix)] > is either a space or ':', to avoid prefix matching more keys than the > actual intended one(s) -- something like: > > char c = line[strlen(prefix)]; > if (c != ':' && !c_isspace(*str)) > continue; We skip the prefix and pass the rest of the line to virHostCPUParseFrequencyString(), which starts by skipping all whitespace and then checking the first non-whitespace character is a semicolon. So I don't see how we could end up matching anything but the intended line.