On Thu, Jan 31, 2019 at 03:34:19PM +0100, Andrea Bolognani wrote:
virtio-mmio is still used by default, so if PCI is desired it's necessary to explicitly opt-in by adding an appropriate
<address type='pci' domain='0x0000' ... />
element to the corresponding device.
Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- src/qemu/qemu_capabilities.c | 4 +++- src/qemu/qemu_domain.c | 2 ++ src/qemu/qemu_domain_address.c | 3 ++- 3 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index f504db7d05..6fe8693170 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -1741,8 +1741,10 @@ bool virQEMUCapsHasPCIMultiBus(virQEMUCapsPtr qemuCaps, /* If ARM 'virt' supports PCI, it supports multibus. * No extra conditions here for simplicity. */ - if (qemuDomainIsARMVirt(def)) + if (qemuDomainIsARMVirt(def) || + qemuDomainIsRISCVVirt(def)) { return true; + }
The comment above only mentions arm. Either decouple the conditions or remove the comment. For simplicity.
return false; }
Reviewed-by: Ján Tomko <jtomko@redhat.com> Jano