Re: [libvirt] [PATCH 2/4] vmwarevertest: drop VIR_FROM_THIS definition
On Thu, Apr 27, 2017 at 09:01:58 +0200, Michal Privoznik wrote:
Firstly, this definition is in a c99 comment, secondly it is not
needed as VIR_FROM_THIS is defined from vmware/vmware_conf.h.
Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
---
tests/vmwarevertest.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/tests/vmwarevertest.c b/tests/vmwarevertest.c
index 3dbe08b..e0e36fe 100644
--- a/tests/vmwarevertest.c
+++ b/tests/vmwarevertest.c
@@ -27,8 +27,6 @@
# include "vmware/vmware_conf.h"
-//# define VIR_FROM_THIS VIR_FROM_NONE
-
This test uses the virAsprintf macro which uses the VIR_FROM_THIS macro.
I think the test file should set it explicitly rather than depend on the
one defined by including the header.
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)