Re: [libvirt PATCH] wireshark: Don't include config.h

On 9/3/20 6:43 AM, Andrea Bolognani wrote: > While both Debian and Fedora include the header in their development > packages for Wireshark, that's not something that the upstream > developers intended and arguably quite wrong, as config.h is obviously > intended to only be used to drive the compilation of Wireshark itself. > The Arch Linux package behaves like the upstream Wireshark package, and > thus libvirt fails to build there. > > It seems that there are multiple bugs to be addressed: > > * libvirt shouldn't include config.h; > > * Debian and Fedora shouldn't be shipping config.h in their Wireshark > packages; > > * Wireshark should not use config.h defines such as HAVE_PLUGINS in > its public headers, and define a public variant of them instead. > > This patch takes care of the first one. > > https://gitlab.com/libvirt/libvirt/-/issues/74 > Signed-off-by: Andrea Bolognani <abologna(a)redhat.com&gt; Funny, just this morning I was grepping for " HAVE_" and " WITH_" in /usr/include, saw a couple of "config.h"s shoot past, and thought "Hmm. That doesn't seem right! Surely those packages didn't *really* intend to ship their config.h with their -dev package". Reviewed-by: Laine Stump <laine(a)redhat.com&gt;