Re: [libvirt] [PATCH v2 1/1] cpu_map.xml: add cmt/mbm feature to x86
On Fri, Jun 24, 2016 at 08:44:50 +0800, Qiaowei Ren wrote:
Some Intel processor families (e.g. the Intel Xeon processor E5 v3
family) introduced some PQos (Platform Qos) features, including CMT
(Cache Monitoring technology) and MBM (Memory Bandwidth Monitoring),
to monitor or control shared resource. This patch add them into x86
part of cpu_map.xml to be used for applications based on libvirt to
get cpu capabilities. For example, Nova in OpenStack schedules guests
based on the CPU features that the host has.
Signed-off-by: Qiaowei Ren <qiaowei.ren(a)intel.com>
---
src/cpu/cpu_map.xml | 11 +++++++++++
1 file changed, 11 insertions(+)
Well, you forgot to run make check.
ACK and pushed with the following patch squashed in.
Jirka
diff --git i/tests/cputestdata/x86-cpuid-Xeon-E5-2630-guest.xml
w/tests/cputestdata/x86-cpuid-Xeon-E5-2630-guest.xml
index 9ff63d7..b02d963 100644
--- i/tests/cputestdata/x86-cpuid-Xeon-E5-2630-guest.xml
+++ w/tests/cputestdata/x86-cpuid-Xeon-E5-2630-guest.xml
@@ -24,6 +24,7 @@
<feature policy='require' name='rdrand'/>
<feature policy='require' name='arat'/>
<feature policy='require' name='tsc_adjust'/>
+ <feature policy='require' name='cmt'/>
<feature policy='require' name='xsaveopt'/>
<feature policy='require' name='pdpe1gb'/>
<feature policy='require' name='abm'/>
diff --git i/tests/cputestdata/x86-cpuid-Xeon-E5-2630-host.xml
w/tests/cputestdata/x86-cpuid-Xeon-E5-2630-host.xml
index a651683..431a737 100644
--- i/tests/cputestdata/x86-cpuid-Xeon-E5-2630-host.xml
+++ w/tests/cputestdata/x86-cpuid-Xeon-E5-2630-host.xml
@@ -24,6 +24,7 @@
<feature name='rdrand'/>
<feature name='arat'/>
<feature name='tsc_adjust'/>
+ <feature name='cmt'/>
<feature name='xsaveopt'/>
<feature name='pdpe1gb'/>
<feature name='abm'/>
diff --git i/tests/cputestdata/x86-cpuid-Xeon-E5-2650-guest.xml
w/tests/cputestdata/x86-cpuid-Xeon-E5-2650-guest.xml
index 9ff63d7..b02d963 100644
--- i/tests/cputestdata/x86-cpuid-Xeon-E5-2650-guest.xml
+++ w/tests/cputestdata/x86-cpuid-Xeon-E5-2650-guest.xml
@@ -24,6 +24,7 @@
<feature policy='require' name='rdrand'/>
<feature policy='require' name='arat'/>
<feature policy='require' name='tsc_adjust'/>
+ <feature policy='require' name='cmt'/>
<feature policy='require' name='xsaveopt'/>
<feature policy='require' name='pdpe1gb'/>
<feature policy='require' name='abm'/>
diff --git i/tests/cputestdata/x86-cpuid-Xeon-E5-2650-host.xml
w/tests/cputestdata/x86-cpuid-Xeon-E5-2650-host.xml
index a651683..431a737 100644
--- i/tests/cputestdata/x86-cpuid-Xeon-E5-2650-host.xml
+++ w/tests/cputestdata/x86-cpuid-Xeon-E5-2650-host.xml
@@ -24,6 +24,7 @@
<feature name='rdrand'/>
<feature name='arat'/>
<feature name='tsc_adjust'/>
+ <feature name='cmt'/>
<feature name='xsaveopt'/>
<feature name='pdpe1gb'/>
<feature name='abm'/>