On 01/05/2013 11:27 AM, Jim Fehlig wrote:
Eric Blake wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=887017 reports that even though libvirt attempts to set fs.aio-max-nr via sysctl, the file was installed with the wrong name and gets ignored by sysctl. Furthermore, 'man systcl.d' recommends that packages install into hard-coded /usr/lib/sysctl.d (even when libdir is /usr/lib64), so that sysadmins can use /etc/sysctl.d for overrides.
* daemon/Makefile.am (install-sysctl, uninstall-sysctl): Use correct location. * libvirt.spec.in (network_files): Reflect this. --- daemon/Makefile.am | 10 ++++++---- libvirt.spec.in | 4 ++-- 2 files changed, 8 insertions(+), 6 deletions(-)
I didn't test this one in my rpm builds, but looks good to me.
ACK.
Thanks for the reviews; I've gone ahead and pushed the series now (trusting that my testing via autobuild.sh is sufficient for this one). I am also in the process of backporting these to v0.10.2-maint, since that is the version used by F18 where the bug report was first raised. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org