Re: [libvirt] [PATCH] build: drop files generated by config.status from tarball

The rule of thumb is that any file generated by config.status is a) reproducible by any user, b) dependent on configure options. Therefore, it is inappropriate to include such generated files in the tarball (for proof, Makefile is generated from Makefile.in; the former is not in the tarball while the latter is). * Makefile.am (EXTRA_DIST): Remove files covered by AC_OUTPUT. --- Tested with 'make distcheck'.  Makefile.am |    4 ++--  1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile.am b/Makefile.am index 0b4ae9d..ecc7435 100644 --- a/Makefile.am +++ b/Makefile.am @@ -16,9 +16,9 @@ XML_EXAMPLES = \  EXTRA_DIST = \   ChangeLog-old \ -  libvirt.spec libvirt.spec.in \ +  libvirt.spec.in \   mingw32-libvirt.spec.in \ -  libvirt.pc libvirt.pc.in \ +  libvirt.pc.in \   autobuild.sh \   Makefile.nonreentrant \   autogen.sh \ -- 1.7.4.4 -- libvir-list mailing list libvir-list(a)redhat.com https://www.redhat.com/mailman/listinfo/libvir-list