Re: [libvirt] PATCH Move misc functions out of hash.c/internal.h intolibvirt.c
On Wed, Oct 29, 2008 at 09:09:05PM +0900, Atsushi SAKAI wrote:
Hi, Dan
I think this patch itself is good for cleanup.
But for libvirt.c itself, the code is very huge.
since this patch adds code to libvirt.(over 6000 lines).
Is there any plan to split libvirt.c in future?
I am just afraid expand the libvirt.c code like qemu/vl.c.
I don't think the size of libvirt.c is much of a problem. There is
not much interesting code in that file - its basically just stubs
implementing the public API, and then immediately calling through
into the internal drivers where the real interesting code is.
The QEMU vl.c files isn't a good comparison point - its contains
piles of complex unrelated code serving all sorts of different
functions - vl.c is like mixing up libvirt.c & 5 other random
files from src/ all in one
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|