On Mon, Dec 18, 2017 at 07:56:51AM -0500, John Ferlan wrote:
v1: https://www.redhat.com/archives/libvir-list/2017-December/msg00543.html
Changes since v1...
* Added a patch to handle a NULL return with pool obj lock
* Alter the IsDuplicate API to use a bool parameter
* Use the IsDuplicate API from the test driver. This would have generated the correct error message about a duplicate UUID instead of the Duplicate key that was generated. Ran virt-manager tests prior to Cole's fixes and of course after.
John Ferlan (3): conf: Need to unlock pools on object allocation failure conf: Use bool for @check_active parameter test: Use virStoragePoolObjIsDuplicate for storage define/create
src/conf/virstorageobj.c | 4 ++-- src/conf/virstorageobj.h | 2 +- src/storage/storage_driver.c | 4 ++-- src/test/test_driver.c | 11 ++++------- 4 files changed, 9 insertions(+), 12 deletions(-)
Reviewed-by: Erik Skultety <eskultet@redhat.com>