Hi, Daniel That's a good idea. Anyway some code seems to be assumed tab = 8spaces(not 4spaces), I hope this kind of mis-spaces will be fixed. Thanks Atsushi SAKAI Daniel Veillard <veillard@redhat.com> wrote:
On Mon, Aug 20, 2007 at 12:58:48PM +0100, Richard W.M. Jones wrote:
Masayuki Sunou wrote:
Hi
Blanks and Tabs coexist in xs_internal.c. This patch replaces a tab by blanks in xs_internal.c.
I'm not sure what our policy is for this. Emacs at least displays and creates the optimal mix of tabs and spaces, and assuming you have a sensible default of tabstops every 8 columns, it'll look fine.
So far I have avoided this kind of patches, it's usually more of a burden than a gain. I will sometime cleanup a full file, but for this I will use the following cb script based on GNU indent, it fixes a lot of things:
paphio:~/libvirt -> cat ~/bin/cb #!/bin/sh indent -bad -bap -bbb -bli4 -br -ce -brs -cs -i4 -l75 -lc75 -nut -sbi4 -psl -saf -sai -saw -sbi4 -ss -sc -cdw -cli4 -npcs -nbc paphio:~/libvirt ->
Daniel
-- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
-- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list