On Fri, 2019-08-16 at 17:10 +0200, Fabiano Fidêncio wrote:
Let's refresh the archived Dockerfiles in order to have the fedora-30 containers performing the MinGW builds (instead of the fedora-rawhide ones).
s/fedora-30/Fedora 30/ s/fedora-rawhide/Fedora Rawhide/ [...]
buildenv-libosinfo-fedora-30.zip | Bin 489 -> 551 bytes buildenv-libosinfo-fedora-rawhide.zip | Bin 572 -> 507 bytes buildenv-libosinfo-ubuntu-16.zip | Bin 558 -> 558 bytes buildenv-libosinfo-ubuntu-18.zip | Bin 558 -> 558 bytes buildenv-libvirt-centos-7.zip | Bin 662 -> 662 bytes [...] buildenv-libvirt-fedora-30.zip | Bin 695 -> 809 bytes buildenv-libvirt-fedora-rawhide.zip | Bin 828 -> 714 bytes buildenv-libvirt-ubuntu-16.zip | Bin 784 -> 784 bytes buildenv-libvirt-ubuntu-18.zip | Bin 783 -> 783 bytes 70 files changed, 0 insertions(+), 0 deletions(-)
Why so much churn? I would expect exactly four files to be changed by this commit. I guess we're not creating our archives in a reproducible fashion, so even if the contents of the Dockerfile are the same we still end up with a nominally different archive. [...]
Binary files a/buildenv-libvirt-fedora-30.zip and b/buildenv-libvirt-fedora-30.zip differ diff --git a/buildenv-libvirt-fedora-rawhide.zip b/buildenv-libvirt-fedora-rawhide.zip index 05ed350..13fe28f 100644 Binary files a/buildenv-libvirt-fedora-rawhide.zip and b/buildenv-libvirt-fedora-rawhide.zip differ diff --git a/buildenv-libvirt-ubuntu-16.zip b/buildenv-libvirt-ubuntu-16.zip index 8cff046..f336d96 100644 Binary files a/buildenv-libvirt-ubuntu-16.zip and b/buildenv-libvirt-ubuntu-16.zip differ diff --git a/buildenv-libvirt-ubuntu-18.zip b/buildenv-libvirt-ubuntu-18.zip index 83546be..9e7126c 100644 Binary files a/buildenv-libvirt-ubuntu-18.zip and b/buildenv-libvirt-ubuntu-18.zip differ
git rightfully refuses to apply this patch, since... Well, there is no patch! Just the description of one :) This, along with the above, means we have still some work ahead of us to adapt to the new container creation workflow. Anyway, I've refreshed the Dockerfiles locally and the diff looks good, so Reviewed-by: Andrea Bolognani <abologna@redhat.com> -- Andrea Bolognani / Red Hat / Virtualization