Re: [PATCH 1/4] virpci: changed the work with PCI via libpciaccess

On Wed, Feb 12, 2025 at 09:42:44AM +0300, Alexander Shursha wrote: Hi, thanks for your contribution, but please be aware of our contribution guidelines: https://libvirt.org/hacking.html and some pages linked from there: https://libvirt.org/best-practices.html https://libvirt.org/submitting-patches.html Mainly the parts about commit messages and formatting multiple patches with a cover letter. I understand you are switching to libpciaccess APIs from our manual handling of PCI devices. That does have the added benefit of working on FreeBSD, but adds a new dependency where it might not have been. That is probably fine, but some more explanation and reasoning would be very beneficial. I would also suggest you install cppi which will then be used in tests as that would show you some indentations to fix (which are hopefully explained in the links above). Using libpciaccess could also help us implement nodedev driver APIs like listing and dumping device info which would then be used to gather more information in order to setup the pass-through from a remote user's perspective, are you planning anything similar? Looking forward to v2. Martin Kletzander