Re: [libvirt] [PATCH] qemu: Allow domain reboot after core dump
On 09/20/2011 05:34 AM, Michal Privoznik wrote:
This patch introduces possibility to reboot domain after core dump
finishes. The new flag VIR_DUMP_REBOOT was added to
virDomainCoreDumpFlags. The new functionality is accessible via virsh
too: virsh dump --reboot<domain>
@@ -3189,6 +3190,11 @@ cleanup:
if (event)
qemuDomainEventQueue(driver, event);
qemuDriverUnlock(driver);
+
+ if ((ret == 0)&& (flags& VIR_DUMP_REBOOT)) {
+ qemuDomainReboot(dom, 0);
You need to check for failure, and propagate that back to the caller.
I like the idea, but the patch needs v2, and this is too risky to push
until after we settle whether there will be a quick 0.9.6.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org