Re: [libvirt] [PATCH 2/4] virsh: Use vshFindDisk and vshPrepareDiskXML in cmdDetachDisk

On 02/03/2012 02:23 AM, Osier Yang wrote:

The first use of the two new helper functions. --- tools/virsh.c | 62 ++++++++------------------------------------------------ 1 files changed, 9 insertions(+), 53 deletions(-)

diff --git a/tools/virsh.c b/tools/virsh.c index ca69f30..5dad1d6 100644 --- a/tools/virsh.c

+ if (!(disk_node = vshFindDisk(doc, target, 0)))

More evidence that VSH_FIND_DISK_NORMAL is not needed, since you passed 0 instead of a name. But overall, looks like a nice re-factorization. ACK. -- Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org