On 12/12/2012 05:23 PM, Eric Blake wrote:
Don't worry about it. There are enough people compiling with newer gcc where the warning is not disabled that you won't be introducing in problems.
heard that too often ;-)
I've send out a new version of the patch (in fact a new series) disabling the warning with a pragma only in the affected file.
But isn't the problem that the use of pragmas to silence broken warnings is specific to newer gcc, while you are trying to silence the warning on older gcc? I guess I'll have to look at what you did; and I still need to work up my patch for the warning avoidance at configure time anyway.
obviously I can't vouch for it ... but according to the GCC manuals, -Wlogical-op was introduced in gcc 4.3 while #pragma GCC diagnostic showed up in gcc 4.2, so we should be safe. But then again, I said that too often as well ... -- Mit freundlichen Grüßen/Kind Regards Viktor Mihajlovski IBM Deutschland Research & Development GmbH Vorsitzender des Aufsichtsrats: Martin Jetter Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294