Re: [PATCH V3] support for hotplug/hotunplug in test hypervisor
On Tue, Oct 31, 2023 at 10:12:51AM +0000, John Levon wrote:
On Tue, Oct 31, 2023 at 10:49:31AM +0100, Michal Prívozník wrote:
> > + VIR_APPEND_ELEMENT(vm->def->hostdevs, vm->def->nhostdevs,
>
> But anyway, I think we want more elaborate approach. The whole point of
> the test driver is to mimic real guest(s) without resources needed. IOW,
Michal, point taken, but are you saying you wouldn't take such a change unless
it implemented attach for all possible devices?
Or would you be OK with a partial implementation that handles hostdev, but
returns the equivalent of ENOTSUP for everything else?
The minimum bar required is "doesn't crash". Right now it'll crash due
to
accessing union branches without checking the type first.
Checking the device type and returning ENOTSUP for things which are not
hostdevs will be sufficient if you don't want to spend time wiring up
other types of device.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|