On Wed, Jul 13, 2011 at 08:38:42AM -0600, Eric Blake wrote:
On 07/13/2011 08:08 AM, Jiri Denemark wrote:
In 2f4d2496a88055a8343b3efca618522da8715d92 I didn't notice that one part of virFileOpenAs doesn't actually call to virFileOpenAsNoFork but rather includes a copy of the code from there. --- src/util/util.c | 35 +++++------------------------------ 1 files changed, 5 insertions(+), 30 deletions(-)
That duplication has been around longer than your change to avoid fchown (in fact, it was around even before I started tweaking things in commit 055d4ff8 to use SCM_RIGHTS, back when it was named virFileOperationNoFork), but this is indeed a nice reduction in code size.
ACK.
Okay, applied and pushed, thanks ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/