Re: [PATCH 1/4] virpci: changed the work with PCI via libpciaccess
On Fri, Mar 07, 2025 at 08:46:23AM +0300, Alexander Shursha wrote:
Martin Kletzander <mkletzan(a)redhat.com> writes:
> I understand you are switching to libpciaccess APIs from our manual
> handling of PCI devices. That does have the added benefit of working on
> FreeBSD, but adds a new dependency where it might not have been. That
> is probably fine, but some more explanation and reasoning would be very
> beneficial.
libpciaccess is already used in libvirt
It is, yes, in one part of the node device driver, to show vendor and
device names. I would just like the commit messages to reflect more what
is being done when looking back at some point in time; that way the
particular changes are easier to understand in years to come.
But mainly, the way the libpciaccess usage is written now in your
patches makes it mandatory to build libvirt, yet it is still presented
as an option in meson_options.txt and meson.build.
https://gitlab.com/libvirt/libvirt/-/blob/master/src/node_device/node_dev...
--
Alexander Shursha
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)