Re: [libvirt] [PATCH 03/12] Move virDomainSnapshot related APIs out of libvirt.c

On 10/22/2014 11:14 AM, Daniel P. Berrange wrote: > Introduce a src/libvirt-domain-snapshot.c file to hold all the > methods related to the virDomainSnapshot type. > --- > docs/apibuild.py | 1 + > po/POTFILES.in | 1 + > src/Makefile.am | 2 + > src/datatypes.h | 1 + > src/libvirt-domain-snapshot.c | 1222 +++++++++++++++++++++++++++++++++++++++++ > src/libvirt.c | 1194 ---------------------------------------- > 6 files changed, 1227 insertions(+), 1194 deletions(-) > create mode 100644 src/libvirt-domain-snapshot.c Reviewed in a similar manner as I mentioned in 2/12, and this one was MUCH easier to validate. ACK, with one question (that may be best handled in a followup for all of the files this series splits out): > +++ b/src/libvirt-domain-snapshot.c > + > +VIR_LOG_INIT("libvirt.domain-snapshot"); > + > +#define VIR_FROM_THIS VIR_FROM_NONE Do we still need VIR_FROM_NONE, or can we switch this file to use VIR_FROM_DOMAIN_SNAPSHOT, now that we are isolated?