Re: [libvirt] [PATCH] libvirt no longer supports qemu format=host_device

On Mon, 2010-11-08 at 10:02 +0000, Daniel P. Berrange wrote: Hmm... that is not clear in the documention IMHO (and the patch was careful to only use this for the qemu driver). Eg from the qemu-img man page: "Supported image file formats: raw ... host_device ... qcow2 ... ... " Ie, the language in the qemu-img man page has 'host_device' at the same level as 'raw', 'qcow2', 'cow', etc as a 'file format'. http://libvirt.org/formatdomain.html#elementsDisks only talks about a 'sub-type' for the qemu driver (but it is easy to infer that it is looking at the qemu-img types after using libvirt for a while) and http://libvirt.org/storage.html does not list 'host_device' as a 'format type', but it does list all of the other ones from the same section of the qemu-img man page (except 'vdi', which is maybe an omission in the libvirt docs?). Finally, 'man virsh' does list 'host_device' as a 'file format' in its 'vol-create-as' command. By all means if this needs to be cleaned up in qemu_conf.c that seems fine, but until then I feel that either host_device should be supported again (preferred based on the qemu-img man page) or the documentation made more consistent, and something probably added in http://libvirt.org/news.html for people upgrading to 0.8.3 or later since libvirt users are hitting this. -- Jamie Strandboge | http://www.canonical.com