Re: [PATCH 2/4] qemu: Support for parsing usb-mtp devices
On 3/8/24 21:16, Rayhan Faizel wrote:
The source tag sets the rootdir property of the device, which is the
directory
exposed to the guest via the MTP device. The target tag sets the desc property.
This device supports read-only mode as well. Like virtiofs, it does not
support additional access modes.
Signed-off-by: Rayhan Faizel <rayhan.faizel(a)gmail.com>
---
src/bhyve/bhyve_command.c | 1 +
src/conf/domain_conf.c | 10 +++++++++
src/conf/domain_conf.h | 1 +
src/conf/schemas/domaincommon.rng | 5 +++++
src/qemu/qemu_command.c | 34 +++++++++++++++++++++++++++++++
src/qemu/qemu_domain_address.c | 7 +++++--
src/qemu/qemu_validate.c | 13 ++++++++++++
7 files changed, 69 insertions(+), 2 deletions(-)
The code is okay, but for future - we tend to split changes a bit
differently: in one patch we do necessary XML parsing & formatting work,
update RNG and docs. Then, in another patch xml -> qemu cmd line
generator is introduced. Reasoning is quite simple - easier backports.
And of course, split between front & back ends.
Now, in the past we used to update tests too: in the commit that
introduces XML parsing & formatting an xml2xml test case was introduced,
then in the other patch (xml -> qemu cmd line) an xml2argv test case was
introdcued. But this is hard to do after qemuxml2xmltest and
qemuxml2argvtest were merged into one. I'm not sure what our
recommendation should be here. For now, I'll just merge qemu command
line generation code AND test cases (patch 3/4) into one.
Let me split changes in patches 2-4 into separate ones.
Michal