Re: [libvirt] [PATCH 2/5] qemu: snapshot: Skip empty drives with internal snapshots
On 04/07/2017 11:50 AM, Peter Krempa wrote:
The code that validates whether an internal snapshot is possible
would
reject an empty but not-readonly drive. Since floppies can have this
property, add a check for emptiness.
---
src/qemu/qemu_driver.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Took a little while to think about this one - but essentially because
LOCATION_NONE is being set when src->readonly (during XML parse) or when
virStorageSourceIsEmpty during virDomainSnapshotAlignDisks, that means
essentially that using LOCATION_NONE is "proper" for those disks and
thus if we find LOCATION_NONE that means we didn't set it that way and
thus the forbid_internal needs to be set.
ACK -
John