13 Jan
2014
13 Jan
'14
10:13 p.m.
On Mon, Jan 13, 2014 at 12:46:44 -0700, Eric Blake wrote:
On 01/13/2014 08:24 AM, Jiri Denemark wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1047577
When writing commit 173c291, I missed the fact virNetServerClientClose unlocks the client object before actually clearing client->sock and thus it is possible to hit a window when client->keepalive is NULL while client->sock is not NULL. I was thinking client->sock == NULL was a better check for a closed connection but apparently we have to go with client->keepalive == NULL to actually fix the crash.
Signed-off-by: Jiri Denemark <jdenemar@redhat.com> --- src/rpc/virnetserverclient.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
ACK.
Pushed, thanks. Jirka