2009/12/23 Diego Elio Pettenò <flameeyes@gmail.com>:
With these variables present, the tests would fail because they are not expected. --- tests/qemuxml2argvtest.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 3b0aa2b..b64dc6a 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -188,6 +188,8 @@ mymain(int argc, char **argv) unsetenv("TMPDIR"); unsetenv("LD_PRELOAD"); unsetenv("LD_LIBRARY_PATH"); + unsetenv("SDL_AUDIODRIVER"); + unsetenv("SDL_VIDEODRIVER");
DO_TEST("minimal", QEMUD_CMD_FLAG_NAME); DO_TEST("machine-aliases1", 0); -- 1.6.6.rc4
You're right, all envvars copied in qemudBuildCommandLine should be unset or set to known values in this testcase to make sure the test is not affected by the actual envvar values. But SDL_VIDEODRIVER is not copied in qemudBuildCommandLine and QEMU_AUDIO_DRV is copied but not unset in the test. I suggest the attached patch. Matthias