On 10/09/09 18:32, Daniel Veillard wrote:
On Fri, Sep 18, 2009 at 05:26:07PM +0200, Wolfgang Mauerer wrote:
Hi,
Hi Wolfgang,
this patch reworks libvirt's disk-hotadd support and introduces support for disk controller hotplugging and disk-hotremove (see http://thread.gmane.org/gmane.comp.emulators.libvirt/15860 for more details). Currently, it targets only qemu and also requires some additions to qemu that have only recently been submitted, which is why this is cross-posted to qemu-devel. Hopefully the lack of support in qemu does not prevent the community from reviewing the code, though ;-)
Could you update us on the status for those patches, is there any chance to get this in QEmu upstream ? I have only seen feddback from Gerd Hoffmann on that thread but maybe I'm missing some of the action !
Note: upstream qemu got device_add and device_del monitor commands meanwhile which can be used to hotplug devices. device_add accepts the same syntax the -device command line switch expects. device_del expectes an id. For libvirt it probably makes sense to start supporting this when switching over to -device (probably for qemu 0.12+). cheers, Gerd