Re: [libvirt] [PATCH 2/2] smbios: support system family

On 12/01/2010 05:12 PM, Eric Blake wrote: Unfortunately, <sysinfo> and <smbios> were never documented in docs/formatdomain.html.in; we'll have to add that before we can add <entry name='family'>string</entry> to that documentation. Don't we typically use '' rather than "" for attribute values? We should probably fix that to be consistent as well. Another problem I just noticed - I can't roundtrip from <smbios mode='host'/> back to the full-blown <smbios mode='sysinfo'/> on my laptop, because my laptop has the following dmidecode entries: Handle 0x0000, DMI type 0, 24 bytes Vendor: LENOVO Version: 6FET82WW (3.12 ) Release Date: 11/26/2009 BIOS Revision: 3.18 Handle 0x0100, DMI type 1, 27 bytes Manufacturer: LENOVO Product Name: 2241B36 Version: ThinkPad T500 Serial Number: R89055N UUID: E321ED02-FAC8-9337-B0E7-C3B32580E899 SKU Number: Not Specified Family: Red Hat Enterprise Linux but the schema only allows: <define name="sysinfo-value"> <data type="string"> <param name='pattern'>[a-zA-Z0-9/\-_\. ]+</param> </data> </define> which rejects my Version string in block 0. -- Eric Blake eblake(a)redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org