On Thu, Nov 04, 2021 at 06:16:19PM +0000, Daniel P. Berrangé wrote:
On Thu, Nov 04, 2021 at 07:08:53PM +0100, Kashyap Chamarthy wrote:
On Thu, Nov 04, 2021 at 01:22:52PM +0100, Michal Privoznik wrote:
It may come handy to be able to tweak TCG options, in this specific case the size of translation block cache size (tb-size). Since we can expect more knobs to tweak let's put them under common element, like this:
<domain> <features> <tcg> <tb-cache unit='MiB'>128</tb-cache>
Any objection to using underscore (tb_cache), instead of hyphen (tb-cache)? I realize the QEMU option uses the hyphen.
We're not entirely consistent, but use of "-" is quite typical in the features:
<kvm> <hidden state='on'/> <hint-dedicated state='on'/> <poll-control state='on'/> <pv-ipi state='off'/> </kvm>
So I think it is right as is.
Fair enough. I asked becuase I did spot the inconsistencies in the other elements under the <features> element, for other hypervisors: <hyperv> ... <vendor_id state='on' value='KVM Hv'/> </hyperv> ... <xen> <e820_host state='on'/> <passthrough state='on' mode='share_pt'/> </xen> ... -- /kashyap