On Wed, Jun 05, 2013 at 05:54:59PM +0800, Chen Fan wrote:
We want to implement the oncrash actions through the thread Pool. so need to define several types for Implementing that options in watchdogAction. --- src/conf/domain_conf.c | 4 ++++ src/conf/domain_conf.h | 4 ++++ 2 files changed, 8 insertions(+)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index f577fd4..1340350 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -477,6 +477,10 @@ VIR_ENUM_IMPL(virDomainWatchdogAction, VIR_DOMAIN_WATCHDOG_ACTION_LAST, "poweroff", "pause", "dump", + "destroy after crashdump", + "reset after crashdump", + "destroy after crash", + "reset after crash", "none")
VIR_ENUM_IMPL(virDomainVideo, VIR_DOMAIN_VIDEO_TYPE_LAST, diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 3a71d6c..bd05c2e 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -1236,6 +1236,10 @@ enum virDomainWatchdogAction { VIR_DOMAIN_WATCHDOG_ACTION_POWEROFF, VIR_DOMAIN_WATCHDOG_ACTION_PAUSE, VIR_DOMAIN_WATCHDOG_ACTION_DUMP, + VIR_DOMAIN_WATCHDOG_ACTION_CRASHDUMP_DESTROY, /* destroy after crashdump */ + VIR_DOMAIN_WATCHDOG_ACTION_CRASHDUMP_RESET, /* reset after crashdump */ + VIR_DOMAIN_WATCHDOG_ACTION_CRASH_DESTROY, /* destroy after crash dircetly */ + VIR_DOMAIN_WATCHDOG_ACTION_CRASH_RESET, /* reset after crash directly */ VIR_DOMAIN_WATCHDOG_ACTION_NONE,
VIR_DOMAIN_WATCHDOG_ACTION_LAST
NACK to this. The guest panick notification is a completely separate mechanism to the guest watchdog device. We should not be overloading watchdog actions for panick handling. Guest panic handling is defined for Xen via the <on_crash>...</on_crash> lifecycle action, and we should use this same syntax for KVM. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|