On 02/09/2011 02:48 AM, Daniel Veillard wrote:
On Tue, Feb 08, 2011 at 01:33:44PM +0100, Michal Novotny wrote:
Hi, this is the patch to add libvirt-php information page with some basic information on libvirt-php project compilation, contribution and other useful information.
Michal
Signed-off-by: Michal Novotny<minovotn@redhat.com> --- docs/bindings.html.in | 13 ++++--- docs/php.html.in | 85 +++++++++++++++++++++++++++++++++++++++++++++++++ docs/sitemap.html.in | 4 ++ 3 files changed, 96 insertions(+), 6 deletions(-) create mode 100644 docs/php.html.in
ACK, pushed !
Thanks for pushing this!
BTW on Fedora 14 I gat many warnings when compiling against php-devel-5.3.5-1.fc14, mostly around add_assoc_string_ex() e.g.:
libvirt.c: In function ‘zif_libvirt_node_get_info’: libvirt.c:613:2: warning: passing argument 4 of ‘add_assoc_string_ex’ makes pointer from integer without a cast /usr/include/php/Zend/zend_API.h:360:45: note: expected ‘char *’ but argument is of type ‘long int’ libvirt.c: In function ‘zif_libvirt_domain_get_name’: libvirt.c:1081:6: warning: assignment discards qualifiers from pointer target type
I wonder if some zend API interface didn't changed at some point leading to this !
Daniel
Yeah, that's right and I'm using Fedora 14 as well but you can ignore the warnings since it's working fine. Of course we should clean them up but I didn't have time to solve this yet. I guess this is some internal error of Zend API interface since "add_assoc_string_ex" function is not used in the code but "add_assoc_string" is used instead. Therefore I guess Zend API is having some macro defined for add_assoc_string() which is buggy. But like I say, it's warning that I was afraid of first as well but I've found out that it's working fine when you ignore those warnings. Michal -- Michal Novotny<minovotn@redhat.com>, RHCE Virtualization Team (xen userspace), Red Hat