Hi, Rich Thank you for your comments. (The primary motivation is take a comments!) I am wondering the libvirt policy about scheduer. And I just know the Xen scheduler only. Is any good idea to support this? Thanks Atsushi SAKAI "Richard W.M. Jones" <rjones@redhat.com> wrote:
Atsushi SAKAI wrote:
Hi,
This patch intends add a showing function of scheduler information. If apply this patch to current revision 1.490 and type virsh dominfo 0 then shows following scheduler information. Currently I assume credit scheduler only. getting function is implemented but setting function is not yet. I just waiting for comments.
Is this part of the patch correct?
diff -urpN libvirt.0329/src/driver.h libvirt.sched2/src/driver.h --- libvirt.0329/src/driver.h 2007-03-16 02:24:57.000000000 +0900 +++ libvirt.sched2/src/driver.h 2007-03-29 19:48:04.000000000 +0900 @@ -146,6 +146,12 @@ typedef int typedef int (*virDrvDomainSetAutostart) (virDomainPtr domain, int autostart); +typedef int + (*virDrvDomainGetSchedInfo) (virDomainPtr domain, + int *autostart); +typedef int + (*virDrvDomainSetSchedInfo) (virDomainPtr domain, + int autostart);
typedef struct _virDriver virDriver; typedef virDriver *virDriverPtr;
My more general comment would be how Xen-specific is this? What scheduler could be used by other drivers? (Obviously qemu just uses the Linux scheduler. However I don't know what kvm uses - whether it also schedules using the Linux scheduler, or some other method).
Rich.
-- Emerging Technologies, Red Hat http://et.redhat.com/~rjones/ 64 Baker Street, London, W1U 7DF Mobile: +44 7866 314 421
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in UK and Wales under Company Registration No. 3798903 Directors: Michael Cunningham (USA), Charlie Peters (USA) and David Owens (Ireland)