Re: [libvirt PATCH 2/3] qemu: fill in domain capabilities for TPMs

On 11/24/21 10:10, Peter Krempa wrote: > On Tue, Nov 23, 2021 at 18:04:07 +0000, Daniel P. Berrangé wrote: >> This reports what TPM features QEMU supports, provided that swtpm is >> installed in the host. >> >> Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com&gt; >> --- > > [...] > >> diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c >> index a4c492dde2..374909bef2 100644 >> --- a/src/qemu/qemu_capabilities.c >> +++ b/src/qemu/qemu_capabilities.c

> diff --git a/tests/domaincapsdata/qemu_2.11.0.s390x.xml b/tests/domaincapsdata/qemu_2.11.0.s390x.xml > index 804bf8020e..f76624ffc8 100644 > --- a/tests/domaincapsdata/qemu_2.11.0.s390x.xml > +++ b/tests/domaincapsdata/qemu_2.11.0.s390x.xml > @@ -205,7 +205,12 @@ > <value>handle</value> > </enum> > </filesystem> > - <tpm supported='no'/> > + <tpm supported='yes'> > + <enum name='model'/> > + <enum name='backendModel'> > + <value>emulator</value> > + </enum> > + </tpm> > </devices> > <features> > <gic supported='no'/> > > Does it even make sense to show that TPM is supported? I think it does. Because domain capabilities XML is not QEMU specific. If 'virsh domcapabilities' was ran against say LXC it wouldn't show TPM. Or am I misunderstanding your question?