Paolo Bonzini <pbonzini@redhat.com> writes:
On 9/25/23 16:48, Alex Bennée wrote:
If we update configure we should make sure we regenerate all the compiler details. We should also ensure those details are upto date before building the TCG tests. Signed-off-by: Alex Bennée <alex.bennee@linaro.org> --- configure | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configure b/configure index e83872571d..a95e0f5767 100755 --- a/configure +++ b/configure @@ -1788,6 +1788,8 @@ for target in $target_list; do echo "HOST_GDB_SUPPORTS_ARCH=y" >> "$config_target_mak" fi + echo "$config_target_mak: configure" >> Makefile.prereqs
This in practice is not adding anything; if "configure" changes then Makefile's dependency on config-host.mak will trigger a configure rerun anyway.
If you want to add it, you should also add it for other config-*.mak files. However, I'd remove this line and just change
-# 1. ensure config-host.mak is up-to-date +# 1. ensure config-host.mak is up-to-date. All other config-*.mak +# files for subdirectories will be updated as well.
Peter ran into a mismatch between config-host.mak and tests/tcg/foo/config-target.mak in his build system so it didn't get picked up at one point.
in the Makefile.
Paolo
-- Alex Bennée Virtualisation Tech Lead @ Linaro