On 01/14/2016 11:27 AM, Peter Krempa wrote:
They are disallowed in the pinning API and as default cpuset.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1293241 --- src/conf/domain_conf.c | 6 ++++++ 1 file changed, 6 insertions(+)
Is this going to be problematic for a running domain? e.g., would it disappear now? I agree with the failure, just worried about the consequences. Not that anyone should have done this, but seems to be one of those post parse, pre-run type checks since it's been allowed in the past. John
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 4b4a36e..1036057 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -14137,6 +14137,12 @@ virDomainVcpuPinDefParseXML(virDomainDefPtr def, if (virBitmapParse(tmp, 0, &vcpu->cpumask, VIR_DOMAIN_CPUMASK_LEN) < 0) goto cleanup;
+ if (virBitmapIsAllClear(vcpu->cpumask)) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("Invalid value of 'cpuset': %s"), tmp); + goto cleanup; + } + ret = 0;
cleanup: