Hi all I have 2 additional suggestions for a smoother build with 1.0.2 * I applied this change in my specfile: http://git.onelab.eu/?p=libvirt.git;a=commitdiff;h=184bc19ce855e1498f6775b71... otherwise like I reported already, I end up with a plain libvirt rpm that requires libvirt-daemon-driver-interface that the build does not produce * this patch here http://git.onelab.eu/?p=libvirt.git;a=blob;f=libcurl-daemon.patch;h=a13198e7... was required on f18 for me as well (this is similar to a change in src/Makefile.am that you guys had pointed me to in the first place) for that to kick in I also had to add 'autoreconf' before %configure in the specfile (I haven't tested with just he autoreconf, that might have been enough ?) IMHO I feel like this would make sense in mainstream, although I would not go as far as to claim that I captured the whole subtlety of that build :-) Thanks anyway for all the hints and help -- Thierry On Feb 20, 2013, at 4:57 PM, Jiri Denemark wrote:
On Tue, Feb 19, 2013 at 15:43:57 -0600, Doug Goldstein wrote:
On Tue, Feb 19, 2013 at 2:54 PM, Jiri Denemark <jdenemar@redhat.com> wrote:
On Tue, Feb 19, 2013 at 14:37:40 -0600, Doug Goldstein wrote:
FWIW, I keep the patchset that I push into Gentoo now in a bit friendlier place to access:
http://git.cardoe.com/?p=libvirt.git;a=shortlog;h=refs/heads/v1.0.2-maint
Due to Gentoo "supporting" each release of libvirt, we'll have a stable branch for every release that others are welcome to follow or look at or make suggestions to include.
Doug, any reason for not having them in upstream libvirt git? We already have maint branches for some releases, which happen to be the releases present in Fedora and the main reason for that is the people maintaining them are mostly interested in Fedora. But we encourage others that are interested in having maint branches for other releases to do so. And the nice thing about it is, that if an ugly bug that has been present in libvirt for a long time may be fixed in all maint branches at once even by people who are really interested in just some of them.
Jirka
No reason not to. I'll gladly add them if people would like that.
Sure, just create v1.0.2-maint branch in upstream git repository and cherry-pick patches there. It's possible git won't let you push the branch, in which case let us know and we'll solve it.
Jirka