Re: [libvirt] [PATCH 2/2] virsh: Really disconnect on keepalive timeout

On Sun, Nov 30, 2014 at 20:09:09 +0100, Martin Kletzander wrote: > Commit 676cb4f4e762b8682a06c6dab1f690fbcd939550 added client keepalive > support for virsh. But because whenever the connection is closed, virsh > tries to reconnect, unless the disconnection happened with the reason > VIR_CONNECT_CLOSE_REASON_CLIENT. Because of that, virsh kept trying to > reconnect even when the connection was closed due to keepalive. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1073506 > > Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com&gt; > --- > tools/virsh.c | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) It's nice this patch makes non-interactive virsh stop, however, it prevents interactive virsh from automatically reconnecting when a next command is issued, which is a very useful feature.