On 06/15/2012 10:24 AM, Doug Goldstein wrote:
On Wed, Jun 13, 2012 at 12:00 PM, Eric Blake <eblake@redhat.com> wrote:
Commit 6e769eba made it a runtime error if libvirt was compiled without yajl support but targets a new enough qemu. But enough users are hitting this on self-compiled libvirt that it is worth erroring out at compilation time, rather than an obscure failure when trying to use the built executable.
* configure.ac: If qemu is requested and -version works, require yajl if qemu version is new enough. * src/qemu/qemu_capabilities.c (qemuCapsComputeCmdFlags): Add comment. --- configure.ac | 19 ++++++++++++++++++- src/qemu/qemu_capabilities.c | 3 ++- 2 files changed, 20 insertions(+), 2 deletions(-)
FWIW, visually inspecting this code I can ACK it. I'll do some test builds with it later.
Thanks for the review. I've gone ahead and pushed this. -- Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org