Re: [libvirt] [PATCH] build: hoist qemu dependence on yajl to configure

On Wed, Jun 13, 2012 at 12:00 PM, Eric Blake <eblake(a)redhat.com&gt; wrote: > Commit 6e769eba made it a runtime error if libvirt was compiled > without yajl support but targets a new enough qemu. But enough > users are hitting this on self-compiled libvirt that it is worth > erroring out at compilation time, rather than an obscure failure > when trying to use the built executable. > > * configure.ac: If qemu is requested and -version works, require > yajl if qemu version is new enough. > * src/qemu/qemu_capabilities.c (qemuCapsComputeCmdFlags): Add > comment. > --- > configure.ac | 19 ++++++++++++++++++- > src/qemu/qemu_capabilities.c | 3 ++- > 2 files changed, 20 insertions(+), 2 deletions(-) >

FWIW, visually inspecting this code I can ACK it. I'll do some test builds with it later.