Re: [PATCH 1/1] nwfilter: Fix deadlock between nwfilter-list and VM startup/migration
On Tue, Feb 18, 2025 at 03:56:32PM +0100, Dion Bosschieter wrote:
A deadlock occurs when `nwfilterBindingCreateXML` and
`nwfilterConnectListAllNWFilters`
acquire locks in an inconsistent order. This patch ensures `nwfilterBindingCreateXML`
acquires `driverMutex` before `updateLock`, resolving the issue.
Additionally, added `driverMutex` to `nwfilterBindingDelete` to maintain consistent
locking order.
Signed-off-by: Dion Bosschieter <dionbosschieter(a)gmail.com>
---
src/nwfilter/nwfilter_driver.c | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange(a)redhat.com>
I've pushed this (92de6563c637dec8abac7ce4794e69fd5896f825) with a massively
expanded commit message explaining how we got into this mess, and an inline
comment reminding us to try to fix it.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|