On 04/26/2018 08:09 PM, John Ferlan wrote:
On 04/15/2018 05:25 PM, Radostin Stoyanov wrote:
> When user-namespace is enabled we are not allowed
> to mount block/NBD devices.
>
> Instead, mount /dev/nbdX to /run/libvirt/lxc/<domain>.root
> and set:
>
> fs->src->path = /run/libvirt/lxc/<domain>.root
> fs->type = VIR_DOMAIN_FS_TYPE_MOUNT
> ---
> src/lxc/lxc_container.c | 53 ------------------------------------------------
> src/lxc/lxc_controller.c | 49 +++++++++++++++++++++++++++++---------------
> 2 files changed, 33 insertions(+), 69 deletions(-)
As John points out, couple of memleaks and also explanation why you're
removing PrepareRoot()?
Otherwise looking good.
Michal