Re: [libvirt] [PATCH] qemu_migration: Don't error on tunelled migration with --copy-storage

On 08/05/2013 04:20 AM, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=979477 > > Since 1.0.3 we are using the new way to copy non shared storage during > migration (the NBD way). However, whether the new or old way is used is > not controllable by user but unconditionally turned on if both sides of > migration support it. Moreover, the implementation is not complete: the > combination for VIR_MIGRATE_TUNNELLED flag is missing (as we need to > open new port on the destination) in which case we just error out. This > is deadly combination: not letting users choose their destiny and s/is/is a/ > erroring out. We should not do that but VIR_WARN and turn the NBD off > instead. > --- > > Probably worth backporting to v1.0.3+ maint branches too. Yep, definitely qualifies as a regression fix. Fedora 19 users will thank you, since that is based on 1.0.5-maint. > > src/qemu/qemu_migration.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) ACK. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org