Re: [libvirt] [PATCH v4 5/8] libxl: add support for CPUID features policy

On 02/08/2018 03:58 PM, Marek Marczykowski-Górecki wrote: > +const char * > +xenTranslateCPUFeature(const char *feature_name, bool from_libxl) > +{ > + static const char *translation_table[][2] = { > + /* libvirt name, libxl name */ > + { "cx16", "cmpxchg16" }, > + { "cid", "cntxid" }, > + { "ds_cpl", "dscpl" }, > + { "pclmuldq", "pclmulqdq" }, > + { "pni", "sse3" }, > + { "ht", "htt" }, > + { "pn", "psn" }, > + { "clflush", "clfsh" }, > + { "sep", "sysenter" }, > + { "cx8", "cmpxchg8" }, > + { "nodeid_msr", "nodeid" }, > + { "cr8legacy", "altmovcr8" }, > + { "lahf_lm", "lahfsahf" }, > + { "cmp_legacy", "cmplegacy" }, > + { "fxsr_opt", "ffxsr" }, > + { "pdpe1gb", "page1gb" }, > + }; In the case of ibrsb and stibp added in xen commit 0d703a701cc and spec-ctrl added in libvirt commit 8b605530e80, have we already encountered the drawback of this approach discussed in V3?