Re: [libvirt] [RFC PATCH 0/5] qemu: drop command line parsing
On Fri, 2019-06-14 at 15:53 +0200, Ján Tomko wrote:
On Fri, Jun 14, 2019 at 03:30:22PM +0200, Peter Krempa wrote:
> All the code is mostly outdated and does not really help in most cases.
>
> Since this was already proposed and I did not see anything against here
> are the patches.
>
> As a follow up I'll refactor and move the rest of qemu_parse_command.c
> once this is out of the way.
>
[...]
drvqemu.html might also need tuning
In addition to that, you need to update the API documentation for
virDomainQemuAttach() and the virsh(1) man page at the very least.
IIRC we have a way to hide virsh commands from the help output: we
probably want to do that, too.
Mentioning this change in the release notes is another no brainer.
Once the stuff mentioned above, the nits I've pointed out separately,
and the issues spotted by Jano have been taken care of, and assuming
we let this sit on the list for a while so that all interested
parties are given a fair chance to express their dissent before it's
pushed, then
Reviewed-by: Andrea Bolognani <abologna(a)redhat.com>
--
Andrea Bolognani / Red Hat / Virtualization