On Mon, Apr 19, 2021 at 12:04:16PM +0100, Daniel P. Berrangé wrote:
On Mon, Apr 19, 2021 at 12:47:59PM +0200, Pavel Hrdina wrote:
> Upstream sheepdog project doesn't have any active development for almost
> 3 years as the last commit is from 28/06/2018 [1].
>
> Looking into repology [2] the latest version 1.0.1 is included only in
> Fedora (since Fedora 26). There are only few other distributions having
> older sheepdog versions: Debian oldstable (stretch), EPEL 6, Ubuntu
> 18.04 and older and few other less-common distributions.
>
> Based on the data above drop support for sheepdog from libvirt.
>
> [1] <
https://github.com/sheepdog/sheepdog/commits/master>
> [2] <
https://repology.org/project/sheepdog/versions>
>
> Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com>
> ---
> docs/formatdomain.rst | 13 +-
> docs/formatstorage.html.in | 5 +-
> docs/schemas/domaincommon.rng | 1 -
> docs/schemas/storagepool.rng | 22 -
> docs/storage.html.in | 59 ---
> src/conf/domain_conf.c | 1 -
> src/conf/storage_conf.c | 12 +-
> src/conf/storage_conf.h | 2 -
> src/conf/storage_source_conf.c | 4 -
> src/conf/storage_source_conf.h | 1 -
> src/conf/virstorageobj.c | 9 -
We don't remove stuff from the XML parser/schema when we drop features,
only remove the implementations behind it, so most of this is not
stuff that should be removed.
Noted, thanks. I'll keep in while posting v2.
It would be nice to figure out some process that would allow us dropping
deprecated features from parser/schema as well so we don't have to keep
the code around.
Pavel