Re: [libvirt] [PATCH v6 0/5] Add TXT record and hosts support for DNS service and dnsmasq command-line regression testing
On Fri, Jun 24, 2011 at 12:04:35PM +0200, Michal Novotny wrote:
Hi,
this is the 6th (and hopefully the last) version of my patch to
introduce the TXT record and DNS hosts support for the DNS service
on the virtual network. This can be defined using the txt
subelement in the dns element of the network XML description.
The definition of TXT record names containing spaces is rejected
with the error message that TXT record names in DNS doesn't
support spaces.
ACK to the patch set, looks clean to me with the small exception
of the code used to grab the hostnames, but that should be cleaned up
as a separate patch,
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/