Re: [libvirt] [PATCH 3/3] conf: Fix error path in virNodeDevPCICapabilityParseXML

If the call to virXPathNodeSet to set naddresses fails, Coverity notes that the subsequent VIR_ALLOC_N cannot have a negative value (well it probably wouldn't be negative per se). Signed-off-by: John Ferlan <jferlan(a)redhat.com&gt; --- src/conf/node_device_conf.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c index a06e450..aed95d5 100644 --- a/src/conf/node_device_conf.c +++ b/src/conf/node_device_conf.c @@ -1305,7 +1305,10 @@ virNodeDevPCICapabilityParseXML(xmlXPathContextPtr ctxt, data->pci_dev.physical_function) < 0) goto out; } else if (STREQ(type, "virt_functions")) { - int naddresses = virXPathNodeSet("./address", ctxt, &addresses); + int naddresses; + + if ((naddresses = virXPathNodeSet("./address", ctxt, &addresses)) < 0) + goto out; if (maxFuncsStr && virStrToLong_uip(maxFuncsStr, NULL, 10,